Skip to content

Update test #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2021
Merged

Update test #19

merged 3 commits into from
Jan 8, 2021

Conversation

@Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 8, 2021

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 8, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 3.36%.

Quality metrics Before After Change
Complexity 3.05 ⭐ 2.60 ⭐ -0.45 👍
Method Length 43.52 ⭐ 38.19 ⭐ -5.33 👍
Working memory 8.28 🙂 7.63 🙂 -0.65 👍
Quality 73.15% 🙂 76.51% ⭐ 3.36% 👍
Other metrics Before After Change
Lines 429 450 21
Changed files Quality Before Quality After Quality Change
bashplot/bashplot.py 66.23% 🙂 66.23% 🙂 0.00%
test/test_bashplot.py 86.79% ⭐ 89.92% ⭐ 3.13% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bashplot/bashplot.py plot 10 🙂 220 ⛔ 10 😞 47.30% 😞 Try splitting into smaller methods. Extract out complex expressions
bashplot/bashplot.py get_args 3 ⭐ 194 😞 10 😞 55.88% 🙂 Try splitting into smaller methods. Extract out complex expressions
bashplot/bashplot.py load_data 0 ⭐ 39 ⭐ 10 😞 78.27% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@Anselmoo Anselmoo merged commit cc0c6db into master Jan 8, 2021
@Anselmoo Anselmoo deleted the coverage branch January 8, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anselmoo